Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(object_recognition_utils): add autoware prefix to object_recognition_utils #8946

Merged
merged 1 commit into from
Oct 15, 2024
Merged

refactor(object_recognition_utils): add autoware prefix to object_recognition_utils #8946

merged 1 commit into from
Oct 15, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Sep 24, 2024

Description

Added autoware prefix to object_recognition_utils

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the prefix-object_recognition_utils branch from 5cc8a60 to c5204bc Compare September 25, 2024 12:58
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:require-cuda-build-and-test labels Sep 25, 2024
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 25, 2024
@esteve esteve force-pushed the prefix-object_recognition_utils branch from c91393a to 3e480a6 Compare September 25, 2024 13:44
@esteve esteve marked this pull request as ready for review September 25, 2024 13:44
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.33333% with 58 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (0de8669) to head (dbe4871).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ction_by_tracker/src/detection_by_tracker_node.cpp 0.00% 9 Missing ⚠️
...ject_merger/src/object_association_merger_node.cpp 0.00% 8 Missing ⚠️
...ccupancy_grid_map/occupancy_grid_map_validator.cpp 0.00% 3 Missing ⚠️
...r_object_tracker/src/radar_object_tracker_node.cpp 0.00% 3 Missing ⚠️
...ject_tracker/lib/tracker/model/bicycle_tracker.cpp 0.00% 2 Missing ⚠️
..._tracker/lib/tracker/model/big_vehicle_tracker.cpp 0.00% 2 Missing ⚠️
...acker/lib/tracker/model/normal_vehicle_tracker.cpp 0.00% 2 Missing ⚠️
...t_tracker/lib/tracker/model/pedestrian_tracker.cpp 0.00% 2 Missing ⚠️
...e_multi_object_tracker/src/processor/processor.cpp 0.00% 2 Missing ⚠️
...racker/model/constant_turn_rate_motion_tracker.cpp 0.00% 2 Missing ⚠️
... and 20 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8946      +/-   ##
==========================================
+ Coverage   27.09%   27.17%   +0.08%     
==========================================
  Files        1300     1312      +12     
  Lines       95810    96038     +228     
  Branches    39122    39208      +86     
==========================================
+ Hits        25955    26095     +140     
- Misses      67257    67331      +74     
- Partials     2598     2612      +14
Flag Coverage Δ *Carryforward flag
differential 20.09% <3.33%> (?)
total 27.11% <ø> (+0.02%) ⬆️ Carriedforward from 0de8669

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

technolojin
technolojin approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen
Copy link
Contributor

@esteve Could you also add the prefix in CODEOWNERS file?

amadeuszsz
amadeuszsz approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for autoware_lidar_transfusion

knzo25
knzo25 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve force-pushed the prefix-object_recognition_utils branch from 3e480a6 to e9474db Compare October 9, 2024 08:32
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Oct 9, 2024
@esteve esteve enabled auto-merge (squash) October 9, 2024 08:32
@esteve
Copy link
Contributor Author

esteve commented Oct 9, 2024

@technolojin @takayuki5168 @amadeuszsz @knzo25 @xmfcx @mitsudome-r I've added the prefix to CODEOWNERS and fixed the conflicts with main, please have a look at the changes. Thanks.

@esteve esteve force-pushed the prefix-object_recognition_utils branch from 3f90fed to ea8c157 Compare October 9, 2024 09:39
@technolojin
Copy link
Contributor

@ktro2828 + @YoshiRi OR @badai-nguyen OR @yukkysaito
Can you review this PR?

@esteve esteve force-pushed the prefix-object_recognition_utils branch from 47ff7a0 to e425469 Compare October 10, 2024 09:48
badai-nguyen
badai-nguyen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YoshiRi
YoshiRi approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my part

@esteve esteve force-pushed the prefix-object_recognition_utils branch 2 times, most recently from 035fd89 to dbe4871 Compare October 15, 2024 07:58
@esteve
Copy link
Contributor Author

esteve commented Oct 15, 2024

@xmfcx would it be possible to merge these changes without waiting for all the reviewers? This PR has already 6 approvals.

@xmfcx xmfcx disabled auto-merge October 15, 2024 11:13
@xmfcx
Copy link
Contributor

xmfcx commented Oct 15, 2024

Waiting for https://github.com/autowarefoundation/autoware.universe/actions/runs/11341739442/job/31550579344 to complete.

@xmfcx
Copy link
Contributor

xmfcx commented Oct 15, 2024 •
edited
Loading

For this PR, I will compile it to make sure and then merge bypassing the requirements.

Moved to issue:

@xmfcx xmfcx mentioned this pull request Oct 15, 2024
Open
@xmfcx xmfcx force-pushed the prefix-object_recognition_utils branch from dbe4871 to 54c5031 Compare October 15, 2024 13:52
@xmfcx
Copy link
Contributor

xmfcx commented Oct 15, 2024

I've compiled it with the latest Autoware and ran

colcon test --event-handlers console_cohesion+ --mixin coverage-pytest --ctest-args -L .* --executor sequential --packages-select $(colcon list --base-paths src/universe/autoware.universe -n | awk '{printf "%s ", $1}')

And it finished successfully.

@xmfcx xmfcx merged commit 95bb2c6 into autowarefoundation:main Oct 15, 2024
21 of 26 checks passed
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 16, 2024
@esteve @prakash-kannaiah
refactor(object_recognition_utils): add autoware prefix to object_rec…
9b593f6 
…ognition_utils (autowarefoundation#8946)

Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: prakash-kannaiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badai-nguyen badai-nguyen badai-nguyen approved these changes

@technolojin technolojin technolojin approved these changes

@amadeuszsz amadeuszsz amadeuszsz approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@YoshiRi YoshiRi YoshiRi approved these changes

@xmfcx xmfcx xmfcx approved these changes

@knzo25 knzo25 knzo25 approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@dan-dnn dan-dnn Awaiting requested review from dan-dnn dan-dnn is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 is a code owner

@manato manato Awaiting requested review from manato manato is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Sensing & Perception Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@esteve @badai-nguyen @technolojin @xmfcx @knzo25 @YoshiRi @takayuki5168 @amadeuszsz